Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Download failed" when downloading from paths including illegal characters. #985

Closed
ToxicMushroom opened this issue Sep 17, 2023 · 4 comments
Closed

"Download failed" when downloading from paths including illegal characters. #985

ToxicMushroom opened this issue Sep 17, 2023 · 4 comments

Comments

@ToxicMushroom
Copy link

ToxicMushroom commented Sep 17, 2023 •
edited
Loading

Problem
When trying to download files containing the colon, or files in folders containing the colon; seafile would throw the not very helpful messages: "Download failed".

Potential solution
Perhaps pre-download checking could be done to make sure the user is not trying to download illegally named files/paths.
And if they are, show a more friendly error like for example "Illegal character : in path"

Discovery
I found this by checking the logcat output when downloading a failing file, which logged a rename warning here:
https://github.com/haiwen/seadroid/blob/edd86098b5769a8f6da258fb3337653ec4d68b8d/app/src/main/java/com/seafile/seadroid2/SeafConnection.java#L631C1-L635C14

I didn't immediately find an official list of illegal characters but from what I read it seems to be the same as FAT32 ?
https://stackoverflow.com/questions/2679699/what-characters-allowed-in-file-names-on-android
@zhwanng
Copy link
Contributor

zhwanng commented Sep 18, 2023

Is that so?
Screenshot_20230918_100445

@ToxicMushroom
Copy link
Author

ToxicMushroom commented Sep 18, 2023 •
edited
Loading

oops meant colon, not semicolon
Ive updated the issue

@zhwanng
Copy link
Contributor

zhwanng commented Sep 18, 2023

Oh, I also reproduced and got the same test result. we will fix this.

zhwanng added a commit to zhwanng/seadroid that referenced this issue Nov 3, 2023
@zhwanng
fix bugs
916536e 
1. [fix] haiwen#985
2.[modify] WRITE_EXTERNAL_STORAGE Modified to MANAGE_EXTERNAL_STORAGE in BrowserActivity
3. fix other bugs
@zhwanng zhwanng mentioned this issue Dec 13, 2023
Merged
freeplant pushed a commit that referenced this issue Dec 13, 2023
@zhwanng
Feat 2.3.6 (#988)
4f4d7f0 
* custom video player UI

* fix bugs

1. [fix] #985
2.[modify] WRITE_EXTERNAL_STORAGE Modified to MANAGE_EXTERNAL_STORAGE in BrowserActivity
3. fix other bugs

* remove useless xml label

* fix a bug

Clicking on an Item of type "/" in an ActivityFragment will toast an internal server error.

* code improvement

1、Fix the bug: when you open the APP, you can't delete the data on the "Starred Files" page when you directly long-press and delete it.
2. Add star feature to the list of libraries.
3. Add star feature to folder list.
4、Folders and libraries on the starred page can be clicked to enter details.
5. Remove the client password feature on the settings page.
6. Modify the API and logic for deleting files/folders.
7. Modify the entity fields of library page, starred page and activity page.
8. Update NavContext class
9. Add storage permission check when entering the home page: different system versions request different storage permissions.

* feat-2.3.6

- Refactoring the SettingsFragment page
- Folder Backup: Add Skip Hidden Files Feature
- Add preview for sdoc format files
- Cleaning up useless code
- Add some util classes

* improve code
@zhwanng
Copy link
Contributor

zhwanng commented Dec 16, 2023

This issue has been resolved, please download the latest version.

@zhwanng zhwanng closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ToxicMushroom @zhwanng