Improve file table sort model #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
修复了 cloud file browser 中排序相关的两个 bug. |
qdbgw3ihnjw
force-pushed
the
improve-file-table-sort-model
branch
from
e3ee038
to
6141421
Compare
lins05
suggested changes
May 15, 2017
src/filebrowser/file-table.cpp
Outdated
| QVariant leftData = source_model_->data(left); | ||
| QVariant rightData = source_model_->data(right); | ||
|
|
||
| if (leftData.type() == QVariant::ULongLong) { |
There was a problem hiding this comment.
应该根据 ModelIndex 是哪一列来决定怎么排序, 而不是根据数据的类型来决定
如果是文件名那一列，就用 digitalCompare, 其它的就用默认的排序
lins05
reviewed
May 15, 2017
src/filebrowser/file-table.cpp
Outdated
| (right.column() == FILE_COLUMN_NAME)) { | ||
| const QString left_name = source_model_->direntAt(left.row())->name; | ||
| const QString right_name = source_model_->direntAt(right.row())->name; | ||
| return digitalCompare(left_name, right_name) < 0 ? true : false; |
There was a problem hiding this comment.
+ return digitalCompare(left_name, right_name) < 0 ? true : false;
后面的 ? true : false 这个不需要吧
qdbgw3ihnjw
force-pushed
the
improve-file-table-sort-model
branch
from
60f772a
to
15c9cc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.