Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seafevents. #198

Merged
merged 1 commit into from Jan 9, 2019
Merged

Support seafevents. #198

merged 1 commit into from Jan 9, 2019

Conversation

cuihaikuo
Copy link
Contributor

No description provided.

@@ -35,6 +35,8 @@ char *topdir = NULL;

char *seafile_ld_library_path = NULL;

gboolean has_seafevents = TRUE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个变量应该放在 SeafileContrller 结构里面,然后在程序启动的时候检查确定一下。

int pid = spawn_process (argv);

g_free (seafevents_config_file);
g_free (seafevents_log_file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个作为 static 变量就不应该被 free 吧。

Copy link
Member

@killing killing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外,SEAHUB_DIR 这个环境变量是否需要设置一下,seafevents 在开源版中有支持发送邮件吗?

@killing killing merged commit 5c8c640 into master Jan 9, 2019
@killing killing deleted the add-seafevents branch April 12, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants