Add option to build websockets #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 17, 2023 15:13
killing
reviewed
Jul 20, 2023
daemon/repo-mgr.c
Outdated
| @@ -6640,7 +6640,7 @@ seaf_repo_manager_del_repo (SeafRepoManager *mgr, | |||
|
|
|||
| pthread_rwlock_unlock (&mgr->priv->lock); | |||
|
|
|||
| #if defined WIN32 || defined __APPLE__ | |||
| #ifdef COMPILE_WS | |||
There was a problem hiding this comment.
这样改的话会影响 windows 和 mac 上面的条件编译吧。应该把 COMPILE_WS 改为 COMPILE_LINUX_WS 然后条件编译改为 if defined WIN32 || defined APPLE || defined COMPILE_LINUX_WS。
killing
reviewed
Jul 20, 2023
| if COMPILE_LINUX_WS | ||
| ws_src = notif-mgr.c | ||
| endif | ||
| endif |
There was a problem hiding this comment.
这里没多，在非MACOS的条件下，判断一下是否有COMPILE_LINUX_WS宏
daemon/repo-mgr.c
Outdated
| @@ -6640,7 +6640,7 @@ seaf_repo_manager_del_repo (SeafRepoManager *mgr, | |||
|
|
|||
| pthread_rwlock_unlock (&mgr->priv->lock); | |||
|
|
|||
| #if defined WIN32 || defined __APPLE__ | |||
| #if defined WIN32 || defined APPLE || defined COMPILE_LINUX_WS | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.