Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not change localhost to '127.0.0.1' #592

Merged
merged 1 commit into from Apr 25, 2014
Merged

Should not change localhost to '127.0.0.1' #592

merged 1 commit into from Apr 25, 2014

Commits on Apr 15, 2014

  1. Should not change localhost to '127.0.0.1' 

    Changing localhost to an IP forces MySQLdb to use a TCP connection, but on unix system, 'localhost' automatically makes MySQLdb use a socket connection which is preferred. If these two odd lines stay, it's impossible to setup a MySQL server with a socket :)

I've tested, and it works simply removing these two. I don't think it should be a problem, if people really wanna use TCP for the local machine, they can still write 127.0.0.1 even though it seems silly.
    @benjaoming
    benjaoming committed Apr 15, 2014
    Copy the full SHA
    87c9782 View commit details
    Browse the repository at this point in the history