Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guests see "join group" button but can't join #90

Closed
jthomaschewski opened this issue Oct 29, 2013 · 9 comments
Closed

Guests see "join group" button but can't join #90

jthomaschewski opened this issue Oct 29, 2013 · 9 comments
Labels

Comments

@jthomaschewski
Copy link

If a guest access a private seafile group via https:///group/ he sees some information about the group (name, creator members...) and the "join group" button.
If the button is clicked an dialog opens with a "verification message" textarea and a submit button. This button doesn't work at all (Neither error nor success)

I think the user should have to register/login first.

@freeplant
Copy link
Member

Yes, the user have to register and login first.

Can you see more about your usage case? So that we can implement it in our
future version.

2013/10/30 jbbr notifications@github.com

If a guest access a private seafile group via https:///group/ he sees
some information about the group (name, creator members...) and the "join
group" button.
If the button is clicked an dialog opens with a "verification message"
textarea and a submit button. This button doesn't work at all (Neither
error nor success)

I think the user should have to register/login first.


Reply to this email directly or view it on GitHubhttps://github.com//issues/90
.

@jthomaschewski
Copy link
Author

Sure, the user has to login first - than everything works as expected.
What I intended to suggest:

When opening the group page without being logged in and clicking "join", the user should be redirected to login form (and back to group page after login)

Currently the button opens a useless dialog - that's confusing.

@xiez
Copy link
Contributor

xiez commented Jan 8, 2014

Join group has been rewrite in 2.1, the group admin will receive notices when someone want to join the group.

@jthomaschewski
Copy link
Author

Thanks a lot!
It's now mostly working as expected. Just one more thing: The notification message for the group admin just contains a link to the group and to the user. There is no "accept" button - neither in the notification nor in the group admin/member list.
So the admin has to manually add the user to the group. Thats ok but an "accept" button would be better in my opinion.

@xiez
Copy link
Contributor

xiez commented Jan 8, 2014

This feature will be added in version 2.2

On Jan 8, 2014, at 8:35 PM, jbbr notifications@github.com wrote:

Thanks a lot!
It's now mostly working as expected. Just one more thing: The notification message for the group admin just contains a link to the group and to the user. There is no "accept" button - neither in the notification nor in the group admin/member list.
So the admin has to manually add the user to the group. Thats ok but an "accept" button would be better in my opinion.


Reply to this email directly or view it on GitHub.

@freeplant
Copy link
Member

This requires modification of database. Our release policy only allow
database modifications at major releases. So you have to wait for version
2.2.

2014/1/8 jbbr notifications@github.com

Thanks a lot!
It's now mostly working as expected. Just one more thing: The notification
message for the group admin just contains a link to the group and to the
user. There is no "accept" button - neither in the notification nor in the
group admin/member list.
So the admin has to manually add the user to the group. Thats ok but an
"accept" button would be better in my opinion.


Reply to this email directly or view it on GitHubhttps://github.com//issues/90#issuecomment-31827501
.

@freeplant
Copy link
Member

join group is removed.

@enno-wattenberg
Copy link

Are there any plans to bring that functionality back. We would like to make groups available in our organisation and allow users to request access to them.

@freeplant
Copy link
Member

We don't have a plan to add this feature back currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants