-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LilyPond: title and subtitle appear incorrect in the reference file #4
Comments
As described in haje61#4 , I believe the existing LilyPond reference file is incorrect. This change updates the reference to a file that (I think correctly) highlights `title` and `subtitle` in the `\header` block.
As described in haje61#4 , I believe the existing LilyPond reference file is incorrect. This change updates the reference to a file that (I think correctly) highlights `title` and `subtitle` in the `\header` block.
Hello Chris,
Thanks for looking into this.
At this moment I am fighting a tumor. I will not spend time on this in the
foreseeable future.
I would like to point out though that it does not make much sense to alter the
xml files. With each update I have always included the latest sml files
directly from Kate. So what you do could eventually be overwritten.
If the xml file is buggy it may be better to contact the author of it.
And yes, if you change an xml file you have to change the corresponding
reference file as well. That is true.
This convert to Alt module for testing intrigues me. I did not know this
existed. So this is the way to test for Perl versions that are not on my
machine. Gonna learn more about it some day.
For now, have a good day.
Thank you.
Best regards,
Hans Jeuken
…On vrijdag 31 januari 2020 05:03:01 CET Chris White wrote:
Thank you for this project! I am hoping to use it in my new static site
generator, App::unbelievable. Please see screenshot below:
![image](https://user-images.githubusercontent.com/10515894/73511619-3de7d80
0-43b4-11ea-9d7c-89524df9e283.png)
The reference file is shown on the top half. The LilyPond output shows that
`title` and `subtitle` are not highlighted (red rectangle). However, as I
am working on
[RT#129134](https://rt.cpan.org/Public/Bug/Display.html?id=129134), it
appears to me they should be. I fixed the regex and got the highlighted
output on the bottom half (blue rectangle). I see from the [LilyPond
docs](http://lilypond.org/doc/v2.18/Documentation/notation/creating-titles-> headers-and-footers#default-layout-of-bookpart-and-score-titles) that
`title` and `subtitle` are valid variables in `\header`, so I think they
should be highlighted along with `composer` and `tagline`. (`year` is not
listed in those docs, so is properly left un-highlighted.)
What do you think? Thank you for considering this question!
|
Hans, Thanks very much for your reply! I am very sorry to hear about the tumor. I wish you a quick and complete recovery! I understand you may not respond, or a response may be delayed. The XML file is not buggy --- Kate's regex syntax is different from Perl's since 5.26. Would it be possible to release a temporary XML patch to fix the test failures? I could then later write a translator that would convert Kate's regex syntax to Perl's. Of course, I would be happy do to the work of making the patch and release if you would be open to that course of action. Thanks, and best wishes! Chris |
Hello Chris, Thank you for your patience. I checked the repository where i get the syntax definitions from. They have not been updated in six years. Do you still have that patch laying around somewhere? Hans |
Thank you for this project! I am hoping to use it in my new static site generator, App::unbelievable. Please see screenshot below:
The reference file is shown on the top half. The LilyPond output shows that
title
andsubtitle
are not highlighted (red rectangle). However, as I am working on RT#129134, it appears to me they should be. I fixed the regex and got the highlighted output on the bottom half (blue rectangle). I see from the LilyPond docs thattitle
andsubtitle
are valid variables in\header
, so I think they should be highlighted along withcomposer
andtagline
. (year
is not listed in those docs, so is properly left un-highlighted.)What do you think? Thank you for considering this question!
The text was updated successfully, but these errors were encountered: