Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LilyPond: title and subtitle appear incorrect in the reference file #4

Open
cxw42 opened this issue Jan 31, 2020 · 3 comments
Open

Comments

@cxw42
Copy link

cxw42 commented Jan 31, 2020

Thank you for this project! I am hoping to use it in my new static site generator, App::unbelievable. Please see screenshot below:

image

The reference file is shown on the top half. The LilyPond output shows that title and subtitle are not highlighted (red rectangle). However, as I am working on RT#129134, it appears to me they should be. I fixed the regex and got the highlighted output on the bottom half (blue rectangle). I see from the LilyPond docs that title and subtitle are valid variables in \header, so I think they should be highlighted along with composer and tagline. (year is not listed in those docs, so is properly left un-highlighted.)

What do you think? Thank you for considering this question!

cxw42 added a commit to cxw42/Kamelon that referenced this issue Jan 31, 2020
As described in haje61#4 ,
I believe the existing LilyPond reference file is incorrect.
This change updates the reference to a file that (I think correctly)
highlights `title` and `subtitle` in the `\header` block.
cxw42 added a commit to cxw42/Kamelon that referenced this issue Jan 31, 2020
As described in haje61#4 ,
I believe the existing LilyPond reference file is incorrect.
This change updates the reference to a file that (I think correctly)
highlights `title` and `subtitle` in the `\header` block.
@haje61
Copy link
Owner

haje61 commented Feb 3, 2020 via email

@cxw42
Copy link
Author

cxw42 commented Feb 7, 2020

Hans,

Thanks very much for your reply! I am very sorry to hear about the tumor. I wish you a quick and complete recovery! I understand you may not respond, or a response may be delayed.

The XML file is not buggy --- Kate's regex syntax is different from Perl's since 5.26. Would it be possible to release a temporary XML patch to fix the test failures? I could then later write a translator that would convert Kate's regex syntax to Perl's. Of course, I would be happy do to the work of making the patch and release if you would be open to that course of action.

Thanks, and best wishes!

Chris

@haje61
Copy link
Owner

haje61 commented May 9, 2022

Hello Chris,

Thank you for your patience.
Fir now I have resolved the issue by removing Lilypond from the test bench.
The other 46 test samples do not show regression.
A new release if available on CPAN.

I checked the repository where i get the syntax definitions from. They have not been updated in six years.
So I am open to your suggestion of improving the xml syntax definitions.

Do you still have that patch laying around somewhere?
Best regards,

Hans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants