Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uidriver/js: Stop initial auto-focusing on Wasm #1373

Closed
hajimehoshi opened this issue Sep 30, 2020 · 4 comments
Closed

uidriver/js: Stop initial auto-focusing on Wasm #1373

hajimehoshi opened this issue Sep 30, 2020 · 4 comments
Labels
bug os:js
Milestone
v2.0.0

Comments

@hajimehoshi
Copy link
Owner

hajimehoshi commented Sep 30, 2020 •
edited

https://paulcockrell.github.io/part3.html (a nice game btw!)

I realized that the Ebiten part takes the focus when the page is shown. This might be annoying.

As #1180 is fixed, we can remove the initial auto focusing easily.
@hajimehoshi hajimehoshi added this to the v2.0.0 milestone Sep 30, 2020
@hajimehoshi hajimehoshi changed the title Stop auto-focusing on Wasm? Stop initial auto-focusing on Wasm? Sep 30, 2020
@hajimehoshi
Copy link
Owner Author

hajimehoshi commented Sep 30, 2020 •
edited

Oh, perhaps, the page itself does that? Then Ebiten is not to blame in this case. Let me confirm.

@hajimehoshi
Copy link
Owner Author

Confirmed this was an issue in Ebiten.

@hajimehoshi
Copy link
Owner Author

795e7c8

The culprit has existed since 6 years ago.

@hajimehoshi hajimehoshi modified the milestones: v2.0.0, v1.12.2 Oct 10, 2020
@hajimehoshi
Copy link
Owner Author

Removing auto-focus could break the backward compatibility unfortunately. As 'set-runnable-on-unfocused' is false in most games in Ebiten 1.x, the iframe would be black without auto-focusing.

As I indicated in the first comment, we can remove this auto-focusing after #1180 is fixed. Then let's set the milestone 2.0.

@hajimehoshi hajimehoshi changed the title Stop initial auto-focusing on Wasm? uidriver/js: Stop initial auto-focusing on Wasm Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os:js
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@hajimehoshi