Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove golang.org/x/sys/windows usages (or give up Go 1.16) #2419

Closed
hajimehoshi opened this issue Oct 29, 2022 · 2 comments
Closed

all: remove golang.org/x/sys/windows usages (or give up Go 1.16) #2419

hajimehoshi opened this issue Oct 29, 2022 · 2 comments

Comments

@hajimehoshi
Copy link
Owner

What feature would you like to be added?

Now Ebitengine uses golang.org/x/sys@v0.0.0-20220818161305-2296e01440c6. I tried to update this to v0.1.0 but failed due to this error (b752a6c):

Error: ../../../go/pkg/mod/golang.org/x/sys@v0.1.0/windows/syscall.go:84:16: undefined: unsafe.Slice
Error: ../../../go/pkg/mod/golang.org/x/sys@v0.1.0/windows/syscall_windows.go:141:29: undefined: unsafe.Slice

unsafe.Slice was introduced at Go 1.17. However, I want to keep supporting Go 1.16 as gccgo still uses Go 1.16.

Then, I'm now considering removing golang.org/x/sys/windows usages.

Why is this needed?

We will be able to update golang.org/x/sys without breaking compatibility with Go 1.16.

@hajimehoshi hajimehoshi added this to the v2.5.0 milestone Oct 29, 2022
@hajimehoshi
Copy link
Owner Author

We have decided to drop Go 1.16.

@hajimehoshi hajimehoshi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant