-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print: Poor Cyrillic support in Map Title, Map comment, when printing a map #1181
Comments
UPDATE: I solved the problem. This fix works with every TTF font , not only Cyrillic.
P.S. I'm sure there is more elegant way to solve this, but I'm a JS noob and for now this is all I can make for the Cyrillic support. I hope this will help, cheers! |
Good job solving it! I found a similar solution when i was investigating it yesterday! I will look into getting the fix into the next release. (We will probably have to incorporate some logic regarding how we select which font that should be set). |
I added a similar solution to yours, (decided to go with the Roboto font, since we use it everywhere else in the application). I added "normal" instead of "bold", and i think it might be a bit to thin? What do you think? @jesade-vbg @jacobwod @OlofSvahnVbg Feel free to test other fonts in this branch: https://github.com/hajkmap/Hajk/tree/fix/1181-cyrillic-print-support |
Hi! I think the Roboto font for Cyrillic texts font is awesome! In Cyrillic glyphs are a way rounded, than in English, so the font is even better in Cyr. Maybe it is not bad idea to have a menu for choosing a font from some pool (with, about 10-15 fonts) in the Print/settings window. But for now-Roboto Normal is very good. Thanks for the fix! |
This is a great find @Hallbergs & @bitmapbulgaria. I took a look at the feature branch and although I agree that we could expand it (by adding a font select menu, etc), I think that this already is a great feature and I'd love seeing it merged. 💯 🥇 Edit: Just adding a note here so we "connect" this issue with the related #502. |
We'll close it when it's merged to master :) |
Description:
When user prints a map with a title and comment, written in Cyrillic, the result is not readable.
On the example, there is two variants of the same print (in English, and in Cyrillic):
English:
Cyrillic:
To Reproduce:
Just try to print a map with a Title and comment in Cyrillic (I used Bulgarian layout) with Print plugin
Instance:
The text was updated successfully, but these errors were encountered: