Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize and localize Hajk #502

Open
jacobwod opened this issue May 5, 2020 · 14 comments
Open

Internationalize and localize Hajk #502

jacobwod opened this issue May 5, 2020 · 14 comments
Labels
idea new feature Request for adding/changing functionality
Projects
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented May 5, 2020

Currently all text strings in Hajk are hard-coded in Swedish. To make this project attract more users and developers, it is essential that the software is engineered in a way that allows for easy localization.

Built-in localization that adapts Hajk's UI according to the user's language preferences is another convenient side effect of this feature.

For more info, see this wiki article.

Below are some articles with examples of different solutions that must be compared before we decide which way to go. The list is in no particular order.

@jacobwod jacobwod added new feature Request for adding/changing functionality idea labels May 5, 2020
@jacobwod jacobwod added this to the 3.x milestone May 5, 2020
@jacobwod jacobwod added this to Approved ideas in Hajk via automation May 5, 2020
@Hallbergs
Copy link
Member

I've done some tests in this branch: https://github.com/hajkmap/Hajk/tree/feature/502-internationalization

First translation added ("core.drawerToggleButton.plugins", Kartverktyg in sv and Tools in en)

The solution uses i18next, react-i18next, and i18next-browser-languagedetector

@jacobwod
Copy link
Member Author

C'est wonderful! 😃

@AndreasAtakan
Copy link

What's the status on this?

I just created a new issue asking about this: #942

@Hallbergs
Copy link
Member

The current status is that the core functionality (switching language in the UI or in the map configuration) has been added, and a couple of components have been migrated to use I18n. Unfortunately, the migration has been put on hold due to other priorities.

However, i still think it is important that this gets done asap, so that organizations outside Sweden can use Hajk! My guess is that this will get done in q1-q2 2022.

@jacobwod
Copy link
Member Author

jacobwod commented Dec 2, 2021

I second @Hallbergs opinion: this is a priority that has been put on hold but we're working on sorting the out the blocking parts so the I18N work can continue. 👍

@matself
Copy link

matself commented Dec 2, 2021 via email

@Hallbergs
Copy link
Member

Translation files (eng and swe) exists on the feature branch for the i18n migration.

This branch is on-hold for the moment since we're currently migrating the application to MUI5, and want to avoid too many merge conflicts. The plan is to get the MUI5 migration done, then merge the the MUI5 migration into the I18n-feature-branch, and then continue the I18n migration.

@matself
Copy link

matself commented Dec 2, 2021 via email

@bitmapbulgaria
Copy link

There is introduction translation in Bulgarian, for the future language localization:

https://drive.google.com/file/d/1nN-K4A3ATYo5ULUPlc3m-mj838-OulBw/view?usp=sharing
Please, add this to the branch, I'll delete the link after that.

@Hallbergs
Copy link
Member

Woho! Nice job!
image

I just pushed it to the branch, so you can go ahead and delete the file.

@bitmapbulgaria
Copy link

Thanks! Will do some polishing, when #502 is complete, but for now is good enough.

@mkoskl
Copy link

mkoskl commented Sep 29, 2023

Is this still relevant issue? Are you working on this?

@jacobwod
Copy link
Member Author

The issue is relevant, but the current maintainers and organisations we represent have not had the resources to implement this ourselves.

Being an open source product, Hajk looks forward to any contributions, including (but not limited to) internationalization efforts. The Hajk maintainers will certainly pay attention to any PR addresses this.

@mkoskl
Copy link

mkoskl commented Oct 2, 2023

Is there any documentation where I could at least look at it? What it requires etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea new feature Request for adding/changing functionality
Projects
Hajk
  
In progress
Development

When branches are created from issues, their pull requests are automatically linked.

6 participants