Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the documenthandler drawerButtonIcon configurable #1219

Closed
lina-sbk-gbg opened this issue Oct 18, 2022 · 5 comments · Fixed by #1255
Closed

Making the documenthandler drawerButtonIcon configurable #1219

lina-sbk-gbg opened this issue Oct 18, 2022 · 5 comments · Fixed by #1255
Assignees
@linusfj
Projects
Hajk
Milestone
3.12

Comments

@lina-sbk-gbg
Copy link

We want to change the icon of the button used to open Dokumenthanterare 2.0.

We suggest making the documenthandler drawerButtonIcon configurable in admin. (in the same way that drawerTitle and drawerButtonTitle are already configurable)
The default icon is suggested to be MenuBook.
@jacobwod
Copy link
Member

Related to #1220. Move to #650?

@Hallbergs
Copy link
Member

Related to #1220. Move to #650?

I agree. Both are good candidates to move to the admin-rebuild.

@linusfj linusfj self-assigned this Dec 6, 2022
@linusfj
Copy link
Member

linusfj commented Dec 7, 2022

Instead of importing all icons from the Material UI library to let the user choose any icon, I've added options with two icons to choose from. The options are configurable via a drop-down menu in admin.

@linusfj linusfj mentioned this issue Dec 7, 2022
Merged
@linusfj linusfj linked a pull request Dec 7, 2022 that will close this issue
Feature/1219 configurable drawer button #1255
Merged
@Hallbergs
Copy link
Member

Hallbergs commented Dec 7, 2022 •
edited
Loading

Hmm. But we're already providing support for any MUI icon in the DocumentHandler? (In the menu-items). Wouldn't that solution work here as well without importing all icons?

@linusfj
Copy link
Member

linusfj commented Dec 8, 2022

Yes, that would work. I've added support to choose any Material UI icon by specifying the name of the icon in admin.

@Hallbergs Hallbergs reopened this Apr 25, 2023
@Hallbergs Hallbergs added this to Approved ideas in Hajk via automation Apr 25, 2023
@Hallbergs Hallbergs added this to the 3.12 milestone Apr 25, 2023
@Hallbergs Hallbergs moved this from Approved ideas to Done in Hajk Apr 25, 2023
@jacobwod jacobwod closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linusfj linusfj

Labels
None yet
Projects
Hajk
  
Done
Milestone
3.12
Development

Successfully merging a pull request may close this issue.

Feature/1219 configurable drawer button hajkmap/Hajk
4 participants
@jacobwod @linusfj @lina-sbk-gbg @Hallbergs