Feature/1219 configurable drawer button #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dynamically import custom icon font and return an icon component. - Enter the name of the icon as a parameter in admin.
Hallbergs
requested changes
Dec 12, 2022
If there is a title, add some margin to the right of the icon.
|
It is still off, check image below: Checking if Also, just curious. Why an |
This solves a bug that added margin to the icon on mobile devices.
|
The icon has been updated to use a custom component instead, which has been styled to not add margin on some viewports. |
…gurable-drawer-button
Hallbergs
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1219.