Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification for cookies usage in Bookmarks plugin #1264

Closed
linusfj opened this issue Jan 11, 2023 · 0 comments
Closed

Add verification for cookies usage in Bookmarks plugin #1264

linusfj opened this issue Jan 11, 2023 · 0 comments
Assignees
@linusfj
Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Milestone
3.12

Comments

@linusfj
Copy link
Member

linusfj commented Jan 11, 2023

Description
The current implementation of the Bookmarks plugin uses localStorage to store bookmarks, but it does not ensure that the user has consented to the use of cookies.

Suggested Solutions

  • Do not store any data in localStorage if the user declines the use of cookies.
  • Inform the user within the plugin if they have declined to use cookies and add a button to enable it again.
@linusfj linusfj added module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality labels Jan 11, 2023
@linusfj linusfj self-assigned this Jan 11, 2023
@jacobwod jacobwod added this to the 3.x milestone Jan 12, 2023
@linusfj linusfj mentioned this issue Feb 6, 2023
Merged
@Hallbergs Hallbergs modified the milestones: 3.x, 3.12 Apr 25, 2023
@jacobwod jacobwod closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linusfj linusfj

Labels
module:client/plugin Functionality that goes into plugins in client new feature Request for adding/changing functionality
Projects
None yet
Milestone
3.12
Development

When branches are created from issues, their pull requests are automatically linked.

feature/1264-bookmarks-cookies-verification hajkmap/Hajk
3 participants
@jacobwod @linusfj @Hallbergs