Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infoclick admin options don't do anything #356

Closed
jacobwod opened this issue Dec 3, 2019 · 3 comments
Closed

Infoclick admin options don't do anything #356

jacobwod opened this issue Dec 3, 2019 · 3 comments
Assignees
@jacobwod
Labels
bug module:admin new feature Request for adding/changing functionality
Projects
Hajk
Milestone
3.2

Comments

@jacobwod
Copy link
Member

jacobwod commented Dec 3, 2019

Problem

Infoclick can be configured in admin among (confusingly) other plugins (even though it's not in /plugin directory in client.

There are multiple options that can be set currently, but none of them do anything except the active/inactive toggle:
bild

Proposed fix

  1. Remove unused options in admin
  2. Add some more options that OpenLayers exposes, so e.g. color of selection can be configured
@jacobwod jacobwod self-assigned this Dec 3, 2019
@jacobwod jacobwod added bug new feature Request for adding/changing functionality module:admin labels Dec 3, 2019
@jacobwod jacobwod added this to Approved ideas in Hajk via automation Dec 3, 2019
@jacobwod jacobwod added this to the 3.2 milestone Dec 3, 2019
@jacobwod jacobwod moved this from Approved ideas to In progress in Hajk Dec 3, 2019
Hajk automation moved this from In progress to Done Dec 3, 2019
@jacobwod
Copy link
Member Author

jacobwod commented Dec 3, 2019

Here's the result, hope you like it:
bild

@sweco-semara
Copy link
Contributor

The coordinates plug-in currently suffers from some hardcoded defaults e.g. icon scale and would also need this kind of flexibility in Hajk's admin offered by the fix for this issue, I have added to our backlog to contribute an improvement inspired by the fix for this issue.

@jacobwod
Copy link
Member Author

jacobwod commented Mar 6, 2024

Looks good @sweco-semara. Feel free to PR when ready. 👍

sweco-semara added a commit to sweco-se/hajk-fork that referenced this issue Mar 8, 2024
@sweco-semara
WIP: SGI coordinate marker scale
849ad13 
Hard-coded for now
TODO: implement config like hajkmap#356
@sweco-semara sweco-semara mentioned this issue Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
bug module:admin new feature Request for adding/changing functionality
Projects
Hajk
  
Done
Milestone
3.2
Development

No branches or pull requests
2 participants
@jacobwod @sweco-semara