Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not wait for all promises to fulfill in Click.js #644

Closed
sweco-seqtob opened this issue Jan 25, 2021 · 3 comments
Closed

Do not wait for all promises to fulfill in Click.js #644

sweco-seqtob opened this issue Jan 25, 2021 · 3 comments
Assignees
@jacobwod
Labels
bug module:client/core Core functionality (not a plugin)
Projects
Hajk
Milestone
3.10

Comments

@sweco-seqtob
Copy link
Contributor

Describe the bug
Click.js is today waiting for all promises to resolve before continuing execution, this means we can get stuck waiting for a getFeatureInfo-request that's not returned from server as a 200 ok.

Expected behavior
Would be better to use Promise.allSettled and let execution continue even though not all requests are coming back as 200 ok

Screenshots
In Click.js row 110 we can change to allSettled (requires additional changes further down to work)
image

Desktop (please complete the following information):
All Browsers
@jacobwod
Copy link
Member

I agree, the proposed solution should work well. 👍

@jacobwod jacobwod added bug module:client/core Core functionality (not a plugin) labels Jan 26, 2021
@jacobwod jacobwod added this to Approved ideas in Hajk via automation Jan 26, 2021
@jacobwod
Copy link
Member

Is there a PR on its way @sweco-seqtob, or did you fix it in sweco/dop-develop?

@Hallbergs Hallbergs moved this from Approved ideas to Issues in Hajk Feb 1, 2021
@sweco-seqtob
Copy link
Contributor Author

No this is still an open issue and up for grabs

@Hallbergs Hallbergs added this to the 3.x milestone Nov 23, 2021
@jacobwod jacobwod moved this from Issues to In progress in Hajk Mar 11, 2022
@jacobwod jacobwod self-assigned this Mar 11, 2022
jacobwod added a commit that referenced this issue Mar 11, 2022
@jacobwod
Partial fix for #644:
6467710 
- If GetFeatureInfo response lacks headers, we no longer fail and get stuck in an ever-spinning-cursor-wheel. Instead, the UI state is reset and any successfull responses are parsed and displayed.
@jacobwod jacobwod modified the milestones: 3.x, 3.10 Mar 11, 2022
@jacobwod jacobwod moved this from In progress to Done in Hajk Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
bug module:client/core Core functionality (not a plugin)
Projects
Hajk
  
Done
Milestone
3.10
Development

No branches or pull requests
3 participants
@jacobwod @sweco-seqtob @Hallbergs