Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that all references to layer are removed when layer is deleted #898

Closed
jacobwod opened this issue Nov 9, 2021 · 0 comments
Closed
Assignees
Labels
bug module:backend MapService stuff plugin:search Functionality and features of the (core) Search plugin
Milestone

Comments

@jacobwod
Copy link
Member

jacobwod commented Nov 9, 2021

Currently when we remove a layer from the layer repository, we also take a look in all map configs and remove the layer's ID from each map's LayerSwitcher options.

Since 22d648e it is possible to also add WMS layers as search sources. In that case the layer's IDs are added to an Array of Search tool's options (searchSources). When we remove a layer from the repository we must also ensure that the possible references to the layer are removed from searchSources, or else we'll have orphaned references left which will cause a crash when loading the Search tool.

@jacobwod jacobwod added bug module:backend MapService stuff plugin:search Functionality and features of the (core) Search plugin labels Nov 9, 2021
@jacobwod jacobwod added this to the 3.8 milestone Nov 9, 2021
@jacobwod jacobwod self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module:backend MapService stuff plugin:search Functionality and features of the (core) Search plugin
Projects
None yet
Development

No branches or pull requests

1 participant