-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/orebro tsm 2 #1281
Feature/orebro tsm 2 #1281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the MenuConnectionSelector
is duplicated? The code is basically the same between all three components. You should create one generic component and re-use that one.
I would suggest reading up on "Thinking in react" or the docs, see: https://beta.reactjs.org/.
Okay, now I have rewritten the code in one component, but I don't know if it's particularly generic because there are 3 different separate columns being displayed. But with this, I may be one step closer to the goal anyway. Thank you for input ! |
Also got rid of some warnings, like `justify` no longer supported etc.
Just added an example of how it can be made more generic. Test it out, and let me know if it works. |
It works very well and is generic in its construction. Very good. |
Gonna let @jacobwod test with his config, then we can merge |
Tested, seems to work as intended so it's good to go for me. |
A development of the tool document manager 2.0 in new-admin so that you can select multiple events in a story map. And in new-client so that you can click on a document link and get multiple events at the same time. You can now also choose to place an event on a headline menu.