Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/orebro tsm 2 #1281

Merged
merged 20 commits into from
Feb 15, 2023
Merged

Feature/orebro tsm 2 #1281

merged 20 commits into from
Feb 15, 2023

Conversation

Sunix71
Copy link
Contributor

@Sunix71 Sunix71 commented Feb 4, 2023

A development of the tool document manager 2.0 in new-admin so that you can select multiple events in a story map. And in new-client so that you can click on a document link and get multiple events at the same time. You can now also choose to place an event on a headline menu.

Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the MenuConnectionSelector is duplicated? The code is basically the same between all three components. You should create one generic component and re-use that one.

I would suggest reading up on "Thinking in react" or the docs, see: https://beta.reactjs.org/.

@Sunix71
Copy link
Contributor Author

Sunix71 commented Feb 8, 2023

Okay, now I have rewritten the code in one component, but I don't know if it's particularly generic because there are 3 different separate columns being displayed. But with this, I may be one step closer to the goal anyway. Thank you for input !

Also got rid of some warnings, like `justify` no longer supported etc.
@Hallbergs
Copy link
Member

Just added an example of how it can be made more generic. Test it out, and let me know if it works.

@Sunix71
Copy link
Contributor Author

Sunix71 commented Feb 8, 2023

It works very well and is generic in its construction. Very good.

@Hallbergs
Copy link
Member

Gonna let @jacobwod test with his config, then we can merge

@jacobwod
Copy link
Member

Tested, seems to work as intended so it's good to go for me.

@Hallbergs Hallbergs merged commit 45eb4ca into develop Feb 15, 2023
@Hallbergs Hallbergs deleted the feature/orebro_tsm_2 branch February 15, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants