Unify build.py #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
py3
branch
3 times, most recently
from
d4fb968
to
821ccb5
Compare
There is no need for two different Python versions – fontforge can support Python 3 just fine. Successfully built with: | Python | fontforge | fonttools | |--------|-----------|-----------| | 2.7.17 | 20190413 | 3.42.0 | | 3.5.9 | 20190413 | 3.42.0 | | 3.7.5 | 20190413 | 3.42.0 | | 3.7.5 | 20190413 | 4.0.2 |
jtojnar
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Dec 25, 2019
Update, clean up and also fix build. Part of the build system still does not support Python 2: hakatashi/RictyDiminished-with-FiraCode#3
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 7, 2020
Update, clean up and also fix build. Part of the build system still does not support Python 2: hakatashi/RictyDiminished-with-FiraCode#3 (cherry picked from commit 5f66351)
hakatashi
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for two different Python versions – fontforge can support Python 3 just fine.
Since Python 2 is dying in less than a week I decided to tweak the scripts to allow running using a single version.
Successfully built with: