Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem on advance heights of some vertical glyphs. #2

Closed
cc4966 opened this issue Sep 3, 2015 · 6 comments
Closed

Problem on advance heights of some vertical glyphs. #2

cc4966 opened this issue Sep 3, 2015 · 6 comments
Assignees
Labels

Comments

@cc4966
Copy link

cc4966 commented Sep 3, 2015

The vmtx table of this font has unexpected values for some glyphs in advance heights or top side bearings: for example, , , and have too big top side bearing or less advance height.
I think that they should have AdnvanceHeight = 2048.
In that case, the corresponding brackets, namely, , , and , also should have AdnvanceHeight = 2048.

@hakatashi
Copy link
Owner

Fmm... it seems that topSideBearing of some glyphs generated by fontforge is accidentally overspaced.

Some notable metrics information about (e.g.) aj674.pw.vert is:

Font advanceHeight topSideBearing
ipam.ttf 1044 328
ipamp.ttf 1044 328
pixiv-novel-font.ttf 1044 1331

Whilst my generatior script has nothing on this glyph, this may be a fontforge bug.

You say, @cc4966, that pixiv-novel-font must have advanceHeight = 2048 and topSideBearing = 328 for this glyph (against the original IPAMincho)? In that case, I can manually set them for erroring glyphs.

@hakatashi
Copy link
Owner

May this help...? http://www.akenotsuki.com/eyeben/fonts/kanren.html

@cc4966
Copy link
Author

cc4966 commented Sep 3, 2015

This problem may be caused by cmap table.
The glyph for U+FF08 is GID+12380 for proportinal, but GID+7380 for monospaced in IPA mincho.
The cmap table of pixiv-novel-font maps U+FF08 to GID+12380 (I assume that this font is monospaced).
Moreover, this cmap has no map of U+FF5E even though IPA mincho has a map.

@cc4966
Copy link
Author

cc4966 commented Sep 4, 2015

The following procedure can be help for this problem.

  1. Decompile the original font by using ttx.
  2. Edit the original font by using FontForge.
  3. Decompile the work by using ttx.
  4. Merge the decompiled data by using a text editor.
  5. Compile the final data by using ttx.

ttx is a font tool in AFDKO.

@hakatashi
Copy link
Owner

This problem may be caused by cmap table.

Uh, I see. I didn't notice the mapping inconsistency. Though topSideBearing of aj674.pw.vert (GID+12595) still seems buggy, mapping U+FF08 to aj7899 (GID+7380) will resolve the problem.
I'll issue the fix soon.

The following procedure can be help for this problem.

Yes TTX is a great tool for font inspection but a tough way to modify and pack fonts by scripting. Merging two fonts is one of the hardest operation on XML, and out of proportion (in contrast to that FontForge has one simple function MergeFonts()).

@hakatashi
Copy link
Owner

Fixed in c38d98f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants