New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplex no longer works with example given in README due to socket.io version discrepancy with revealjs.jit.su #1276
Comments
Thanks @FGHASS for finding this version incompatibility. Do you mind providing a PR to fix this URL? |
Yes the PR is trivial, but I've noticed that if I use the updated socket.io client in conjunction with the notes plugin, then instead of the next slide I only ever see the current slide in the speaker console. This applies only to the master presentation, i.e. the one where the socket.io secret is non-null, and the speaker console does work as expected on slaves. Is this a new problem, or has this existed before? |
The socket.io server at reveal.jit.su has been updated with socket.io 1.x, which means the examples referring to 0.9.x client libraries no longer work. Update them with URLs for 1.3.5. Fixes hakimel#1276.
Hi why not update the socket.io in the package.json? I can see that it's still using 0.9.16 |
@jereme-leandev please feel free to do that. I'm not sure if @hakimel has any intention to merge this PR though; it's been sitting in the queue for more than a month... |
Thanks for digging into this. The PR you submitted was merged and reveal.js now uses a more recent version of socket.io. However I needed to make some changes to how multiplexing works as part of the dependency update so it's no longer compatible with the version at revealjs.jit.su. I'll file a new issue for asking the person who operates that server to update it once these changes have had some time to be tested and are merged into master. |
@hakimel Thanks! So to clarify, does this mean that a presentation using current master will not work with multiplexing via revealjs.jit.su? |
Neither master or dev currently work. Also just saw that the server is moving: https://github.com/hakimel/reveal.js/pull/1357/files I'm starting to wonder if it might just be easier to switch the examples in the readme to run the server locally. |
The README currently gives this example for a multiplex configuration:
Evidently, the socket.io server at revealjs.jit.su has been upgraded to a 1.x version, with which the 0.9.16 client library is incompatible, resulting in an HTTP 400 (Bad Request) error.
Updating the client socket.io library to 1.3.5 makes the problem go away; thus the correct socket.io source URL appears to be
//cdn.socket.io/socket.io-1.3.5.js
.The text was updated successfully, but these errors were encountered: