Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-transition not working #2237

Closed
reagle opened this issue Sep 26, 2018 · 4 comments
Closed

data-transition not working #2237

reagle opened this issue Sep 26, 2018 · 4 comments

Comments

@reagle
Copy link

reagle commented Sep 26, 2018 •
edited
Loading

#1947 reports data-transition on vertical slides doesn't work, but I can't get convex, concave, or zoom to work on any per-slide transitions. See the slides following this one.
@reagle
Copy link
Author

reagle commented Sep 27, 2018

To clarify, the transition effects work when they are set globally, whether horizontal or vertical. For example, this global convex setting works:

https://reagle.org/joseph/talks/2014/exemplar.html?transition=convex

The problem is with per-slide transitions. @hakimel's demo slides don't have per slide transitions (except on the background), so it's difficult to isolate.

Next step, I will download the demo slides and see if they work there.

@reagle
Copy link
Author

reagle commented Sep 27, 2018

When I add data-transition attributes to slides in the official demo set, they work on horizontal but not on vertical/nested. So #1947 is the most important bug. (My slides are generated via pandoc so there might be something there causing a problem too but that is hard to say until #1947 is addressed.)

@reagle
Copy link
Author

reagle commented Sep 27, 2018

I've determined my horizontal slides are not working because pandoc wraps all top level sections -- except the title-slide -- in a superfluous <section> element. This means all my slides suffer from issue #1947. I'll close this issue #2237, ask about this pandoc behavior on their list, and clarify #1947.

<body>
  <div class="reveal">
    <div class="slides">

      <section id="title-slide">
        <h1 class="title">Habits</h1>
        <p class="author">John Doe</p>
        <p class="date">March 22, 2005</p>
      </section>

      <section>
        <section id="in-the-morning" class="title-slide slide level1"><h1>In the morning</h1></section>
        <section id="getting-up" class="slide level2">

@reagle reagle closed this as completed Sep 27, 2018
@reagle reagle mentioned this issue Sep 27, 2018
Open
@ayhankesicioglu
Copy link

ayhankesicioglu commented Jun 6, 2020 •
edited
Loading

#1515 (comment)
I fixed my transitions problem on bootstrap4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reagle @ayhankesicioglu