URI encode name hash #2037
Closed
URI encode name hash #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! This has been merged into the dev branch and will make its way out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named link derived from slide id attributes with accentuated or special characters can't be found back in the slideshow when reading a URL. For instance the id "lemon-soufflé" produces the hash "lemon-souffl" which, when entered, can't be linked to the correct slide. The fix proposed in this PR consists in URI encoding the id value to form the hash and URI decoding the hash to locate the slide by its id.
This is linked to issue 1346 and related issues.