Fix if-statement in readURL #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
called even when the current slide is the target slide.
|
Good catch thanks for the fix! |
This was referenced Apr 1, 2019
This was referenced Apr 6, 2020
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Fix if-statement in readURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected a nested if statement in readURL() that caused slide(indexh,indexv) to be called even when the current slide equals the target slide pointed to by the read URL.
In the uncorrected version, any slide switch triggers a call to slide(h,v), which calls writeURL(), which triggers readURL(), which then erroneously triggers slide(h,v) a second time.
As a consequence, updateBackground() is called twice (from slide(h,v)) for each slide change. When using background videos the first call starts the video. The second call first stops the video (through stopEmbeddedContent(previousBackground)) and then tries to restarts it again. This unfortunate start-stop-start combination in most cases does not start the background video, but triggers the following error (on Ubuntu 18.04 w/ chromium browser):
"Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause()."
Correcting the if-statement in readURL fixes the issue.