honor slide number config in pdf mode #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsutherland
force-pushed
the
pdf-slide-numbers
branch
from
f584f60
to
cd0041c
Compare
djsutherland
force-pushed
the
pdf-slide-numbers
branch
from
cd0041c
to
afdb220
Compare
djsutherland
force-pushed
the
pdf-slide-numbers
branch
from
afdb220
to
77d10dd
Compare
djsutherland
force-pushed
the
pdf-slide-numbers
branch
from
77d10dd
to
c189a21
Compare
|
This is great! Thanks for a thorough PR that covers all the cases. |
This was referenced Jan 29, 2020
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
print-pdfmode always usesh.vslide numbers. This change makes it support any format.This required changing the API of the custom slide number function from #2315. Since that's only been in
devfor less than a month, I imagine it's not widely used yet, and using the old style of function would only breakprint-pdfnumbering and not regular numbers anyway.