Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes: Introduce alternate pacing timer, based on total presentation time #2400

Merged
merged 2 commits into from
May 27, 2019

Commits on May 12, 2019

  1. Notes: Introduce alternate pacing timer, based on total presentation …

    …time
    
    The current pacing timer operates on the assumption that there is
    a default amount of time to be allocated to each slide, and that
    individual slides can deviate from that default by specifying their
    own data-timing attribute.
    
    This patch introduces an alternate pacing method: by specifying
    the totalTime configuration option, the presenter can set the total
    time available to present. The pacing timer will then continue to
    allocate the exact pacing time for slides that do have data-timing
    set, as before. However, rather than applying the defaultTiming
    constant to all others, it will
    
    - Add up the time already allocated to slides via data-timing;
    - subtract that from totalTime;
    - divide the difference by the number of slides without data-timing set;
    - apply the thus-calculated average to those slides.
    
    totalTime has no default, and if both defaultTiming and totalTime are
    set, totalTime wins. This preserves backward compatibility: if a
    presenter has set defaultTiming and updates reveal.js, totalTime will
    be null and defaultTiming is still applied to all slides without a
    data-timing attribute. The presenter can then switch to the automatic
    calculation, if desired, by setting a value for totalTime.
    fghaas committed May 12, 2019
    Configuration menu
    Copy the full SHA
    078ba62 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Notes: Weakly enforce a minimum allocated pacing time per slide

    When using the totalTime-based pacing calculation, a presenter may
    inadvertently set totalTime and per-slide data-timing attributes in
    such a way that the pacing time for some slides is impossibly low or
    even negative.
    
    Add a check to ensure that the pacing on a slide never falls below a
    configurable minimum, defaulting to 0. Display an alert if the
    pacing for any slide(s) falls below the threshold.
    fghaas committed May 22, 2019
    Configuration menu
    Copy the full SHA
    23c12d7 View commit details
    Browse the repository at this point in the history