Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement data-markdown-text attribute #2890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement data-markdown-text attribute #2890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/markdown.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@

<div class="slides">

<!-- Set markdown text directly, slides are separated by newline + three dashes + newline, vertical slides identical but two dashes -->
<section data-markdown-text="%23%20Setting%20Markdown%20Text%20Demo%0A%0A---%0A%0A%23%23%20Set%20Text%201.1%0A%0AContent%201.1%0A%0ANote%3A%20This%20will%20only%20appear%20in%20the%20speaker%20notes%20window.%0A%0A--%0A%0A%23%23%20Set%20Text%201.2%0A%0AContent%201.2%0A%0A---%0A%0A%23%23%20Set%20Text%202%0A%0AContent%202.1%0A%0A---%0A%0A%23%23%20Set%20Text%203.1%0A%0AContent%203.1%0A%0A--%0A%0A%23%23%20Set%20Text%203.2%0A%0AContent%203.2%0A%0A--%0A%0A%23%23%20Set%20Text%203.3%0A%0A%21%5BExternal%20Image%5D%28https%3A//s3.amazonaws.com/static.slid.es/logo/v2/slides-symbol-512x512.png%29%0A" data-separator="^\n---\n$" data-separator-vertical="^\n--\n$"></section>

<!-- Use external markdown resource, separate slides by three newlines; vertical slides by two newlines -->
<section data-markdown="markdown.md" data-separator="^\n\n\n" data-separator-vertical="^\n\n"></section>

Expand Down
18 changes: 16 additions & 2 deletions plugin/markdown/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ const Plugin = () => {

// disregard attributes that are used for markdown loading/parsing
if( /data\-(markdown|separator|vertical|notes)/gi.test( name ) ) continue;
if( /data\-markdown\-text/gi.test( name ) ) continue;

if( value ) {
result.push( name + '="' + value + '"' );
Expand Down Expand Up @@ -206,9 +207,22 @@ const Plugin = () => {

var externalPromises = [];

[].slice.call( scope.querySelectorAll( '[data-markdown]:not([data-markdown-parsed])') ).forEach( function( section, i ) {
[].slice.call( scope.querySelectorAll( '[data-markdown-text], [data-markdown]:not([data-markdown-parsed])') ).forEach( function( section, i ) {

if( section.getAttribute( 'data-markdown' ).length ) {
var markdownText = section.getAttribute( 'data-markdown-text' );

if( markdownText ) {

// Set markdown text directly
section.outerHTML = slidify( unescape(markdownText), {
separator: section.getAttribute( 'data-separator' ),
verticalSeparator: section.getAttribute( 'data-separator-vertical' ),
notesSeparator: section.getAttribute( 'data-separator-notes' ),
attributes: getForwardedAttributes( section )
});

}
else if( section.getAttribute( 'data-markdown' ).length ) {

externalPromises.push( loadExternalMarkdown( section ).then(

Expand Down