Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp: fixing base path for 'package' task #3156

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

dennybiasiolli
Copy link
Contributor

@dennybiasiolli dennybiasiolli commented Mar 16, 2022

Without this, the zip created does not contains the working directory structure.

@hakimel hakimel merged commit d80a8d6 into hakimel:master Mar 21, 2022
hakimel added a commit that referenced this pull request Mar 21, 2022
@hakimel
Copy link
Owner

hakimel commented Mar 21, 2022

Thanks! I also dropped the full asset build and tests running ahead of creating a ZIP.

@dennybiasiolli dennybiasiolli deleted the fix-gulp-package branch March 21, 2022 09:08
@dennybiasiolli
Copy link
Contributor Author

Great, thank you!

samwize pushed a commit to samwize/reveal.js that referenced this pull request Jun 9, 2022
* hakimel/master: (1422 commits)
  tweak slides mention
  fix issues with overflowing fit-text when exporting to pdf hakimel#3191 hakimel#3120
  Fix typo in plugin.js
  notes plugin only listens for same-origin postmessages to prevent xss
  new attempt at speaker view xss fix
  add support for 'data-background-gradient' hakimel#2510
  fix issue where auto-animate did not work when jumping three or more slides (i.e. longer than the view distance)
  made data-background attribute work with .webp hakimel#3200
  fix: truncated long r-fit-text on pdf
  update link
  fix issue with hakimel#3182 when slide numbers are disabled
  fix inconsistent fragment visibility in looping presentations hakimel#3123
  fix: pdf page numbering for fragment group
  always use css transforms for presentation scaling (zoom has too many quirks even if it is slightly sharper on ldpi displays)
  update lock file
  4.3.1
  notes plugin allows messsages from current/upcoming slide windows
  fix hakimel#3154
  fix vertical slide link in demo hakimel#3155
  dont run full build + tests for package task hakimel#3156
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants