Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Touch events don't work on IE10 #450

Closed
wants to merge 1 commit into from
Closed

Conversation

sarvaje
Copy link

@sarvaje sarvaje commented May 8, 2013

Hello,

I add the necessary script to add the set msTouchAction style to "none" for work on IE10 touch.

Note: only reveal.js was modified, you need to create minified version.

@hakimel
Copy link
Owner

hakimel commented May 8, 2013

Wait so setting msTouchAction to none is all that's needed? That's great. There's been a long discussion about fixing this in #300 and a solution was never reached.

Seems like you accidentally committed a change to index.html though.

@sarvaje
Copy link
Author

sarvaje commented May 8, 2013

sorry, I commited a change on index.html only for use reveal.js intead reveal.min.js. Because I don't commited the minified version.

When you use mspointers and gestures on IE10, you need to set the msTouchAction to none, using javascript or using css (-ms-touch-action: none). I think that is better using javascript version, so the user doesn't need to configure nothing :)

@sarvaje
Copy link
Author

sarvaje commented May 8, 2013

If you found some problem with touch on IE10, please, tell me :)

@hakimel
Copy link
Owner

hakimel commented May 8, 2013

Cool, I don't have anything with IE10 on to test but I'll merge this in soon.

@sarvaje
Copy link
Author

sarvaje commented May 8, 2013

Nice!!

@owenversteeg
Copy link
Contributor

Wow! I'll test this soon. Thanks!

@owenversteeg
Copy link
Contributor

Works like a charm. Thanks so much!

If you see #300 you can see that I tried this via CSS but had no luck. I guess JS was the way to go!

@sarvaje
Copy link
Author

sarvaje commented May 10, 2013

@owenversteeg your CSS doesn't work because you put that on html tag. I usually put that CSS on body tag, but in this case I put that on wrapper, because how this is a library, I don't want to interfence with other elements.

But usually you can use CSS or javascript style and is the same thing. :)

@owenversteeg
Copy link
Contributor

aha. Yeah, in hindsight I should've tried the wrapper.

I know JS/CSS usually does the same thing but sometimes it turns out differently because of CSS importances.

hakimel added a commit that referenced this pull request May 12, 2013
@hakimel
Copy link
Owner

hakimel commented May 12, 2013

I moved this to the CSS, since you said that would work. Feels more appropriate than setting through JS since it's a CSS property. It has been merged into the dev branch – I have not been able to if one of you can confirm that it works that would be great.

@owenversteeg
Copy link
Contributor

@hakimel Yep, moving it to CSS still works. Tested on IE10 on Windows 8 just a few seconds ago.

enovajuan pushed a commit to enovajuan/reveal.js that referenced this pull request Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants