Fixed Panic and added support for printing errors - AssociatedIPs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checking for HTTP response status code
Added check to prevent a panic (pulled from subdomains.go). Also added printing of the error message so that the tool doesn't silently fail.
|
Initial behavior: Behavior after fix:
|
|
Nice one thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the associated IP's command, if your SecurityTrails subscription didn't support that feature, this tool crashed. I pulled a fix from commit #79fcb965aec519c6e4dba0b9d630eab189cfa913 and place it in associatedips.go.
I also added support in utilities.go to grab the response code to be used for validating that the request was valid (response 200).
I also added a defer to close the http request once we are done with it.