Corrected implementation in pure-python version of I_DK #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonsbm
pushed a commit
that referenced
this pull request
Oct 1, 2018
Rename variables and reorder ifs for better logic
hakonsbm
pushed a commit
that referenced
this pull request
Mar 19, 2019
Added spike pairing test for hh_psc_alpha_clopath + minor corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends your Python2-fixing PR with a correct implementation of I_DK. Simply renaming
m_inftom_DKcorrectly reflects the fact thatmfor this channel is not a long-term asymptotic value, but an instant transform ofD, which evolves over time.