HAL-1824: add a confirmation check for replacing deployments #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @michpetrov! I'll need some time until I can review the PR. I'm busy with other tasks. |
|
The PR looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: HAL-1824
@hpehl I tried to refactor the current columns since there's a lot of duplicate code, I will add a second commit with the actual checks. The props class isn't ideal but I couldn't think of a better solution.
Also, I'm not quite sure about the distinction between Content/Deployment/ServerGroupDeployment, i.e. atm Deployment extends Content even though Content has serverGroups which don't make sense for Deployment (it is only used in standalone), whereas ServerGroupDeployment has a lot of common methods with Content but does not extend it. I didn't want to mess with it more than I had to.