BZ119170: JCA Resource Adapter creation error is 'Unknown Error'

hal · Apr 1, 2015 · 67c19b9 · 67c19b9
1 parent 2f5a0a0
commit 67c19b9
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/gui/src/main/java/org/jboss/as/console/client/core/UIMessages.java b/gui/src/main/java/org/jboss/as/console/client/core/UIMessages.java
@@ -266,4 +266,6 @@ public interface UIMessages extends Messages {
     String patch_manager_restart_verify(String host);
 
     String bs_interface_warning(String url);
+
+    String failedToAddResourceAdapter(String name);
 }
diff --git a/gui/src/main/java/org/jboss/as/console/client/core/UIMessages.properties b/gui/src/main/java/org/jboss/as/console/client/core/UIMessages.properties
@@ -46,6 +46,7 @@ environment_description=A map of names and values of all system properties.
 extensions_description=The list of installed extensions. Each extension reflects a subsystem.
 failed=Failed: {0}
 failedToAdd=Failed to add {0} to {1}.
+failedToAddResourceAdapter=Failed to add resource adapter {0}.
 failedToDisable=Failed to disable {0}.
 failedToEnable=Failed to enable {0}.
 failedToRemoveFrom=Failed to remove {0} from {1}.

diff --git a/...src/main/java/org/jboss/as/console/client/shared/subsys/jca/ResourceAdapterPresenter.java b/...src/main/java/org/jboss/as/console/client/shared/subsys/jca/ResourceAdapterPresenter.java
@@ -13,8 +13,11 @@
 import com.gwtplatform.mvp.client.proxy.PlaceManager;
 import com.gwtplatform.mvp.shared.proxy.PlaceRequest;
 import com.gwtplatform.mvp.client.proxy.Proxy;
+import com.allen_sauer.gwt.log.client.Log;
+
 import org.jboss.as.console.client.Console;
 import org.jboss.as.console.client.core.NameTokens;
+import org.jboss.as.console.client.core.message.Message;
 import org.jboss.as.console.client.domain.model.SimpleCallback;
 import org.jboss.as.console.client.shared.BeanFactory;
 import org.jboss.as.console.client.shared.model.ModelAdapter;
@@ -364,12 +367,15 @@ public void onCreateAdapter(final ResourceAdapter ra) {
         System.out.println(operation);
 
         dispatcher.execute(new DMRAction(operation), new SimpleCallback<DMRResponse>() {
-
-            @Override
-            public void onFailure(Throwable caught) {
-                super.onFailure(caught);
-                loadAdapter(false);
-            }
+
+			@Override
+			public void onFailure(Throwable caught) {
+				Log.error("Unknown error", caught);
+				Console.getMessageCenter().notify(
+						new Message(Console.MESSAGES.failedToAddResourceAdapter(ra
+										.getName()), caught.getMessage(), Message.Severity.Error));
+				loadAdapter(false);
+			}
 
             @Override
             public void onSuccess(DMRResponse dmrResponse) {