[JBEAP-5040] No simple way to refresh the Runtime -> Subsystems -> JN… #263
Conversation
| /** | ||
| * @author Martin Stefanko | ||
| */ | ||
| public interface JndiViewManagement { |
There was a problem hiding this comment.
Could you elaborate what's the reasoning behind this interface.
There was a problem hiding this comment.
There is no specific need for it. I made it to group possible further extensions or features to be added to the JndiPresenter class. In my opinion, it is no direct association to the funcionality the class should represent. There is very similar interface TXMetricManagement.
Thank you for the review. If you wish, there is no problem to remove it.
There was a problem hiding this comment.
I think it's not necessary to have this interface now. IMO interfaces make sense when there are more than one implementation. I see your point regarding TXMetricManagement, but TBH I think this interface could be removed as well.
A generic RefreshMetrics interface, which is implemented by all metric presenters, would make sense to me. But that would be a bigger refactoring.
To sum it up: Could you please remove TXMetricManagement
There was a problem hiding this comment.
Sure, do you want me to delete both interfaces in one commit ? Do I understand correctly ?
There was a problem hiding this comment.
Sorry for the confusion. There was a typo in my last comment. I meant only to remove the JndiViewManagement interface.
…DI view
JBEAP: https://issues.jboss.org/browse/JBEAP-5040
JIRA: https://issues.jboss.org/browse/HAL-1139