Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

[HAL-865] - Refresh button on webservices runtime view does not refreh statistics #77

Merged
merged 1 commit into from Oct 18, 2016

Conversation

dpospisil
Copy link
Contributor

@@ -215,5 +215,14 @@ public void updateEndpoints(List<WebServiceEndpoint> endpoints) {
ColumnSortEvent.fire(table, table.getColumnSortList());

table.selectDefaultEntity();
SingleSelectionModel<WebServiceEndpoint> selectionModel =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would turn the selectionModelinto a member variable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the member variable selectionModel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

  • D.

On Wednesday, September 30, 2015 02:22:31 AM Harald Pehl wrote:

@@ -215,5 +215,14 @@ public void updateEndpoints(List
endpoints) {>
ColumnSortEvent.fire(table, table.getColumnSortList());

     table.selectDefaultEntity();
  •    SingleSelectionModel<WebServiceEndpoint> selectionModel =
    

Please use the member variable selectionModel


Reply to this email directly or view it on GitHub:
https://github.com/hal/core/pull/77/files#r40773928

@dpospisil
Copy link
Contributor Author

@hpehl Thanks for the review! Comments incorporated.

@hpehl hpehl changed the title [HAL865] - Refresh button on webservices runtime view does not refreh statistics [HAL-865] - Refresh button on webservices runtime view does not refreh statistics Sep 30, 2015
@hpehl
Copy link
Member

hpehl commented Nov 16, 2015

Waiting on pm_ack for https://bugzilla.redhat.com/show_bug.cgi?id=1135137

@ppalaga
Copy link

ppalaga commented Oct 14, 2016

@hpehl please merge. Brad has recently added https://bugzilla.redhat.com/show_bug.cgi?id=1135137 to EAP 6.4.12 payload.

@hpehl hpehl merged commit d45bcec into hal:2.5.x Oct 18, 2016
@hpehl hpehl removed the needs_ack label Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants