Use JsType+Global.JSON instead AutoBean and fix gwt-maven-plugin #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configuration Version rc-7 requires type:gwt-lib to correctly configure dependencies using devmode goal.
ibaca
commented
May 21, 2017
| @@ -41,6 +41,7 @@ | |||
| <dependency> | |||
| <groupId>org.jboss.gwt.elemento</groupId> | |||
| <artifactId>elemento-core</artifactId> | |||
| <type>gwt-lib</type> | |||
There was a problem hiding this comment.
this is not required, but as you are defining the version in the parent pom, this makes this version used by this dependency. You can instead remove the type and use ${project.version}.
ibaca
commented
May 21, 2017
| @@ -102,6 +102,7 @@ | |||
| <groupId>org.jboss.gwt.elemento</groupId> | |||
| <artifactId>elemento-core</artifactId> | |||
| <version>${project.version}</version> | |||
| <type>gwt-lib</type> | |||
There was a problem hiding this comment.
this fixes devmode... see tbroyer/gwt-maven-plugin#86
ibaca
commented
May 21, 2017
| <plugin> | ||
| <groupId>net.ltgt.gwt.maven</groupId> | ||
| <artifactId>gwt-maven-plugin</artifactId> | ||
| <inherited>false</inherited> |
There was a problem hiding this comment.
not inherited! this is only used during development to run devmode.
|
+1 @ibaca. Replacing AutoBean with JsType+Global.JSON is great idea. |
|
Uhm, I'm going to split this PR in 2, 1.for autobean and another to the plugin, because the plugin configuration is no very IDE friendly, and because I just see that you use develop branch instead of master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version rc-7 requires type:gwt-lib to correctly configure dependencies using devmode goal. And also, I have added a gwt maven plugin configuration to the root pom, I'm not sure how you are using devmode right now, but I think that you need to install before you can use it, isn't it? Now you can just use gwt:devmode in the root module and it just loads 3 examples at the same time.
I'm not sure if you really want to use AutoBean on purpose, but I think that if you are using elemental2 hehe you better do it all without "old gwt" magic. Using JsType+Global.JSON is the new AutoBean 😛.