Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only complete pointer paths now considered intersecting #107

Conversation

XedinUnknown
Copy link
Contributor

This fixes #106 by adding a path separator to terminate each pointer when comparing for intersection.

@mad-briller
Copy link

i ran into this issue recently and this would be a great change if it works as anticipated

however the tests in this PR only test the outcome of the validator and not the actual parser when used with intersecting pointers, perhaps that would be a good thing to also test?

it may be that the algorithm simply will not handle intersection of any type in the keys
i'm not super knowledgable on the parser itself and assume you have done some testing of the outcome locally however?

@XedinUnknown
Copy link
Contributor Author

Hi @mad-briller! I've done testing, sure, and it works for me in a project.

Regarding parser testing, I'm not sure if it's actually a part of the parser's concern. But if it is, I'm also not that knowledgeable about parsers. In fact, there are #105 and #108 that would need someone with parser experience to fix. If you'd like, I can give you write access to the repo with the fix, and feel free to add more tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b3aa89) 100.00% compared to head (1581575) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #107   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       184       184           
===========================================
  Files             17        17           
  Lines            526       526           
===========================================
  Hits             526       526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@halaxa halaxa merged commit fa4f5a3 into halaxa:master Nov 26, 2023
3 checks passed
@XedinUnknown XedinUnknown deleted the fix/non-intersecting-pointers-considered-intersecting branch November 27, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-Intersecting Pointers Considered Intersecting
4 participants