Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex values in ignore don't seem to work #28

Closed
MathewKostiuk opened this issue Jun 22, 2022 · 3 comments
Closed

Regex values in ignore don't seem to work #28

MathewKostiuk opened this issue Jun 22, 2022 · 3 comments
Labels
question Further information is requested

Comments

@MathewKostiuk
Copy link

Hi there,

I'm working with the Tomorrow Agency where we're using Kit. I'm looking to prevent the templates/*.json files from being deployed but I'm not having success with the Regex pattern. Here's my kit.config.js:

module.exports = {
  ignore: [
    /templates\/.*[.]json/
  ],
}

However, I still see the JSON templates being uploaded when running kit deploy. This is with the ignore key in the top-level after module.exports. I've also tried with ignore nested within the individual environments and I see the same results there.

Other files are ignored if I add in the full path.

Kit version: 1.1.1

Is this a known issue? I'm happy to provide any other information that may help debugging, just let me know!

Thank you

@maxrolon
Copy link
Collaborator

Hey @MathewKostiuk We've just deployed 1.1.2 which should include this functionality. Can you try this again and let me know if the issue persists?

@maxrolon maxrolon added the question Further information is requested label Aug 23, 2022
@MathewKostiuk
Copy link
Author

@maxrolon Thanks for the response! I've just tried this again with the updated version and it's working just as expected. kit.config.js is looking much better now!

@maxrolon
Copy link
Collaborator

@MathewKostiuk Awesome! In the future I can get back to you faster, sorry for the delay with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants