Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github-style status badges? #2

Closed
zahhar opened this issue Jul 10, 2020 · 5 comments
Closed

Github-style status badges? #2

zahhar opened this issue Jul 10, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@zahhar
Copy link

zahhar commented Jul 10, 2020

Hi,

Halfmoon is amazing project, thank you for starting it.
Now I am working on a status page and I am missing Github-style badges.
Bootstrap does not have it either, and all badge generators I found (e.g. shields.io) provide only images, but not the markup.

So I came up with something that covers my needs, take a look: https://jsfiddle.net/zahhar/8ezmnLy9/3/

Will be happy to improve (dark mode, links, unification with existing badges - you name it) and create PR if you think this is valuable addition to Halfmoon.

@halfmoonui
Copy link
Owner

Hey, thanks for the kind words. Regarding the image based status badges, I think the main reason for providing support for images only (and not markup) is because these images are mostly used on READMEs. However, this is certainly not a bad idea. Halfmoon has a few missing group components, namely button groups, so badge groups could also be a nice addition.

@zahhar
Copy link
Author

zahhar commented Jul 12, 2020

@halfmoonui - may I ask you to share some tips for contributors? I am not sure if I should change halfmoon-variables.css or halfmoon.css, for example. Or probably you actually have source files for every component + variables file separately, that get linted together into resulting halfmoon.css?

Anyhow, appreciate some guidance before I create a PR.

@halfmoonui
Copy link
Owner

@zahhar Yes sure. Basically, I do not have source files for every component, instead it is just the two monoliths. I usually add the changes the halfmoon-variables.css file first, and then to the halfmoon.css file. If everything works as expected, the code is minified and pushed to git.

@haguezoum
Copy link

haguezoum commented Jul 12, 2020 via email

@halfmoonui halfmoonui added the enhancement New feature or request label Jul 23, 2020
@halfmoonui
Copy link
Owner

@zahhar This has been added in v1.1.0. Link: https://www.gethalfmoon.com/docs/badges/#badge-group

I will go ahead and close this issue. You can re-open it if you think the issue is still not resolved, or open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants