Fixing shapekey issue and Tasty Rig deform bone scaling when scaleDown=false #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bmarquez1997
changed the title
|
Also added the changes I made to make the version of 2.1.5 that I uploaded in case it was easier to use them from a PR |
|
merging other pr #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a skin with the Tasty (IK) rig and Scale Down set to false, the plugin would fail in the middle of setting up the Tasty Rig (on line 1912), causing the IK components to not get set up. The issue was that in python, (x, y, z) * 100 is (x, y, z, x, y, z,, ... ) instead of (100x, 100y, 100z). It looks like other places above used Vector(x, y, z) when multiplying with scale, so I changed the line that was throwing the error to the same format