Skip to content

Commit

Permalink
Merge remote-tracking branch 'plashchynski/fix_kaminari_vs_will_pagin…
Browse files Browse the repository at this point in the history
…ate_conflict_bug'
  • Loading branch information
mshibuya committed May 4, 2012
2 parents e8daf7f + 1f33823 commit 0d80b74
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
4 changes: 3 additions & 1 deletion lib/rails_admin/adapters/active_record.rb
Expand Up @@ -35,7 +35,9 @@ def all(options = {}, scope = nil)
scope = scope.where(model.primary_key => options[:bulk_ids]) if options[:bulk_ids]
scope = scope.where(query_conditions(options[:query])) if options[:query]
scope = scope.where(filter_conditions(options[:filters])) if options[:filters]
scope = scope.page(options[:page]).per(options[:per]) if options[:page] && options[:per]
if options[:page] && options[:per]
scope = scope.send(Kaminari.config.page_method_name, options[:page]).per(options[:per])
end
scope = scope.reorder("#{options[:sort]} #{options[:sort_reverse] ? 'asc' : 'desc'}") if options[:sort]
scope
end
Expand Down
8 changes: 5 additions & 3 deletions lib/rails_admin/adapters/mongoid.rb
Expand Up @@ -35,11 +35,13 @@ def all(options = {},scope=nil)
scope = scope.any_in(:_id => options[:bulk_ids]) if options[:bulk_ids]
scope = scope.where(query_conditions(options[:query])) if options[:query]
scope = scope.where(filter_conditions(options[:filters])) if options[:filters]
scope = scope.page(options[:page]).per(options[:per]) if options[:page] && options[:per]
if options[:page] && options[:per]
scope = scope.send(Kaminari.config.page_method_name, options[:page]).per(options[:per])
end
scope = sort_by(options, scope) if options[:sort]
scope
end

def count(options = {},scope=nil)
all(options.merge({:limit => false, :page => false}), scope).count
end
Expand Down Expand Up @@ -317,7 +319,7 @@ def association_foreign_key_lookup(association)
association.foreign_key.to_sym rescue nil
end
end

def association_type_lookup(macro)
case macro.to_sym
when :belongs_to, :referenced_in, :embedded_in
Expand Down
4 changes: 2 additions & 2 deletions lib/rails_admin/extensions/history/history.rb
Expand Up @@ -54,7 +54,7 @@ def self.history_for_model(model, query, sort, sort_reverse, all, page, per_page
else
history = history.order('created_at DESC')
end
all ? history : history.page(page.presence || "1").per(per_page)
all ? history : history.send(Kaminari.config.page_method_name, page.presence || "1").per(per_page)
end

def self.history_for_object(model, object, query, sort, sort_reverse, all, page, per_page = (RailsAdmin::Config.default_items_per_page || 20))
Expand All @@ -65,6 +65,6 @@ def self.history_for_object(model, object, query, sort, sort_reverse, all, page,
else
history = history.order('created_at DESC')
end
all ? history : history.page(page.presence || "1").per(per_page)
all ? history : history.send(Kaminari.config.page_method_name, page.presence || "1").per(per_page)
end
end
4 changes: 2 additions & 2 deletions lib/rails_admin/extensions/paper_trail/auditing_adapter.rb
Expand Up @@ -69,7 +69,7 @@ def listing_for_model(model, query, sort, sort_reverse, all, page, per_page = (R
versions = Version.where :item_type => model.model.name
versions = versions.where("event LIKE ?", "%#{query}%") if query.present?
versions = versions.order(sort_reverse == "true" ? "#{sort} DESC" : sort)
versions = all ? versions : versions.page(page.presence || "1").per(per_page)
versions = all ? versions : versions.send(Kaminari.config.page_method_name, page.presence || "1").per(per_page)
versions.map{|version| VersionProxy.new(version, @user_class)}
end

Expand All @@ -83,7 +83,7 @@ def listing_for_object(model, object, query, sort, sort_reverse, all, page, per_
versions = Version.where :item_type => model.model.name, :item_id => object.id
versions = versions.where("event LIKE ?", "%#{query}%") if query.present?
versions = versions.order(sort_reverse == "true" ? "#{sort} DESC" : sort)
versions = all ? versions : versions.page(page.presence || "1").per(per_page)
versions = all ? versions : versions.send(Kaminari.config.page_method_name, page.presence || "1").per(per_page)
versions.map{|version| VersionProxy.new(version, @user_class)}
end
end
Expand Down

0 comments on commit 0d80b74

Please sign in to comment.