-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent LLVM trunk builds seem to have broken predicated_store_load #3534
Comments
I noticed massive performance issues with masked vector store instructions on x86. It's not supposed to be non-temporal anymore, but subsequent loads of an address that you do a masked store to take forever, so it seems like it has left cache. I just turned them off entirely in the autoscheduler branch and was going to propose turning them off in master for x86 for now. |
+1, make it so |
Did you do that locally? I don't see it in the branch. |
With that in place, the branch is still failing; e.g. #3535 which is up to date with standalone_autoscheduler still fails predicated_load_store |
It fails it because it's not generating any predicated stores, and the test asserts that it does. |
d'oh |
Disable predicated store/load on x86 (Issue #3534)
Looks like we never followed up on this -- probably worth revisiting to see if the 'recent LLVM trunk breakage' is still a thing. |
I'm going to assume this is long-since-stale |
Haven't investigated yet, just opening an issue for tracking.
The text was updated successfully, but these errors were encountered: