CSE should not lift out all true predicate from load/store #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharletg
reviewed
Jan 19, 2017
| @@ -58,11 +58,6 @@ bool should_extract(Expr e) { | |||
| return !is_const(a->stride); | |||
| } | |||
|
|
|||
| if (const Call *a = e.as<Call>()) { | |||
There was a problem hiding this comment.
I think we still shouldn't lift loads out of address_of. address_of is broken if it's operand isn't a Load. predicated load/store isn't the only possible use of this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for Codegen OpenCL correctness_mul_div_mod test. If the load/store predicate is trivially true, CSE shouldn't lift it out from the expr.