Fix simplifier bug (Issue #1760) #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, driveby change to add logging for Stmt mutations as well as Expr mutations to SImplify, and to enable/disable them via ifdef.
abadams
reviewed
Jan 20, 2017
| // was being simplified incorrectly, but *only* if var was of type Bool. | ||
| Stmt then_clause = AssertStmt::make(b2, Expr(22)); | ||
| Stmt else_clause = AssertStmt::make(b2, Expr(33)); | ||
| check(IfThenElse::make(b1 == true, then_clause, else_clause), |
There was a problem hiding this comment.
(b1 == True) should probably simplify to b1. If it doesn't now, it probably will in the future. So this test might not actually test the thing you want. Maybe b1 == b2?
There was a problem hiding this comment.
Good point. Changed to b1 == b2 (and verified that this still triggered the issue if the fix is backed out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, driveby change to add logging for Stmt mutations as well as Expr
mutations to SImplify, and to enable/disable them via ifdef. (Fixes Issue #1760)