fix bounds inference bug for bounded interval / unbounded interval #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will clone this to get it to run on the buildbots. Stand by. |
abadams
added
the
backport me
abadams
approved these changes
Oct 6, 2020
alexreinking
pushed a commit
that referenced
this pull request
Oct 16, 2020
fix bounds inference bug for bounded interval / unbounded interval
alexreinking
removed
the
backport me
alexreinking
pushed a commit
that referenced
this pull request
Oct 18, 2020
fix bounds inference bug for bounded interval / unbounded interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in bounds inference engine, discussed with @abadams @shoaibkamil @alexreinking and @jn80842 .
Maximum value possible from dividing a bounded interval (a0, a1) buy an unbounded interval is max(-a0, a1), which correspond to the cases that a0 is negative but greater in magnitude than a1 (and divided by -1), or where a1 is the maximum possible value (divided by 1).