-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3925 : Remove hvx_64 #5365
Merged
Merged
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
048999c
Remove MAKE_ID_PAIR and IdPair
pranavb-ca 6371ef9
remove the uses of hvx_64 from Halide/src
pranavb-ca b121015
Remove use of hvx_64 from Halide/test
pranavb-ca 18b704b
Remove use of hvx_64 from apps
pranavb-ca a33b3fc
remove use of hvx_64 from Target.cpp
pranavb-ca 2554e60
fix intrinsic ids
pranavb-ca 3316566
Remove all definitions of hvx_64
pranavb-ca 609840c
Look for Target::HVX too, everywhere that we look for Target::HVX_128
pranavb-ca 9a96a46
Clean up some nonsensical code related to hvx in apps
pranavb-ca 09f9eda
[camera_pipe] - In hvx_128 we need 4 threads to saturate hvx with work
pranavb-ca 13a4eb1
Merge branch 'master' into pdb_remove_hvx_v64
pranavb-ca 4d1a4bb
Fix bad merge of test/correctness/mul_div_mod.cpp
pranavb-ca 04cd8dd
Remove hvx_64 and hvx to python bindings
pranavb-ca 8151b77
Check only for Target::HVX
pranavb-ca 16604ae
Set vector_size to 128. rule out vector sizes that made sense on HVX_…
pranavb-ca 2cde234
prefer using HVX over HVX_128
pranavb-ca 85f143c
Address review comments
pranavb-ca 00ae979
Merge branch 'master' into pdb_remove_hvx_v64
steven-johnson 7fdd42c
clang-format
steven-johnson 5e91d6f
clang-format
steven-johnson c2c35b3
remove hvx_64 from Halide/Makefile
pranavb-ca b2c9769
Merge branch 'master' into pdb_remove_hvx_v64
pranavb-ca e520503
Merge branch 'master' into pdb_remove_hvx_v64
steven-johnson d94e7a7
Update CodeGen_Hexagon.cpp
steven-johnson File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,8 +39,8 @@ class Median3x3 : public Generator<Median3x3> { | |
output.dim(0).set_min(0); | ||
output.dim(1).set_min(0); | ||
|
||
if (get_target().features_any_of({Target::HVX_64, Target::HVX_128})) { | ||
const int vector_size = get_target().has_feature(Target::HVX_128) ? 128 : 64; | ||
if (get_target().features_any_of({Target::HVX, Target::HVX_128})) { | ||
const int vector_size = get_target().features_any_of({Target::HVX, Target::HVX_128}) ? 128 : 64; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. constant 128 |
||
Expr input_stride = input.dim(1).stride(); | ||
input.dim(1).set_stride((input_stride / vector_size) * vector_size); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the HVX_128 branch, not the HVX_64 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I jumped the gun a little bit here. Newer cores have 4 contexts, but presently the lowest we support still has 2 contexts. I'll switch it back to
/ 2 ;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Actually, I think having more strips than cores is fine, so maybe keeping this 4 is best.