Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to bounds inference on shift_left #5477

Merged
merged 22 commits into from
Dec 4, 2020
Merged

Fixes to bounds inference on shift_left #5477

merged 22 commits into from
Dec 4, 2020

Commits on Nov 22, 2020

  1. Add shift_left fix for signed integers by possibly negative values + … 

    …regression test
    @rootjalex
    rootjalex committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    2c308ac View commit details
    Browse the repository at this point in the history

  2. add required condition on shift_left integer fix

    @rootjalex
    rootjalex committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    54f5f74 View commit details
    Browse the repository at this point in the history

  3. add type check to shift_left minimum condition

    @rootjalex
    rootjalex committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    04311b6 View commit details
    Browse the repository at this point in the history

  4. fix constant folding of shifts with |b| >= type.bits() for types that… 

    … allow overflow (failes correctness/simplify test)
    @rootjalex
    rootjalex committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    a3f3323 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. make regression tests use scoped bindings

    @rootjalex
    rootjalex committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    d9230a6 View commit details
    Browse the repository at this point in the history

  2. change condition in case int24/int48 proposal happens soon

    @rootjalex
    rootjalex committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    084976e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Merge branch 'master' of https://github.com/halide/Halide into ajr-sh… 

    …ift-fix
    @rootjalex
    rootjalex committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    a81a878 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. revert changes based on overflow expectations

    @rootjalex
    rootjalex committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    1d14dc6 View commit details
    Browse the repository at this point in the history

  2. add more regression tests

    @rootjalex
    rootjalex committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    9898a11 View commit details
    Browse the repository at this point in the history

  3. clarify comment

    @rootjalex
    rootjalex committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    9d5b35d View commit details
    Browse the repository at this point in the history

  4. add shift_left min handler for b only UB

    @rootjalex
    rootjalex committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    0594730 View commit details
    Browse the repository at this point in the history

  5. fix clang-tidy complaint

    @rootjalex
    rootjalex committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    030d36d View commit details
    Browse the repository at this point in the history

  6. relax shift_left of non-negative value constraint

    @rootjalex
    rootjalex committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c4b7b8a View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. pull case outside of unnecessary preconditions

    @rootjalex
    rootjalex committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    e8bcdf2 View commit details
    Browse the repository at this point in the history

  2. fix clang-format complaint

    @rootjalex
    rootjalex committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    343b5b0 View commit details
    Browse the repository at this point in the history

  3. fix broken precondition

    @rootjalex
    rootjalex committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    86e362e View commit details
    Browse the repository at this point in the history

  4. add typecheck to possibly save a can_prove() call

    @rootjalex
    rootjalex committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    b725708 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. add easy-out type check to precondition

    @rootjalex
    rootjalex committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    3055665 View commit details
    Browse the repository at this point in the history

  2. Add descriptive comment to bug fix + add another early-exit precondition

    @rootjalex
    rootjalex committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    1a8930e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Merge branch 'master' into rootjalex/shift_left_fix

    @steven-johnson
    steven-johnson committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    89b0e19 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rootjalex/shift_left_fix

    @steven-johnson
    steven-johnson committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    153871f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into rootjalex/shift_left_fix

    @steven-johnson
    steven-johnson committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    983e492 View commit details
    Browse the repository at this point in the history