Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obscure bug in widening let substitution #6405

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Conversation

abadams
Copy link
Member

@abadams abadams commented Nov 10, 2021

No description provided.

@abadams abadams added backport me This change should be backported to release versions bug labels Nov 10, 2021
Copy link
Contributor

@shoaibkamil shoaibkamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, subtle. Thanks for the quick fix!

@abadams abadams merged commit d343e76 into master Nov 11, 2021
@abadams
Copy link
Member Author

abadams commented Nov 11, 2021

Failure was unrelated

derek-gerstmann pushed a commit to derek-gerstmann/Halide that referenced this pull request Nov 12, 2021
Fix obscure bug in widening let substitution

(cherry picked from commit d343e76)
derek-gerstmann pushed a commit that referenced this pull request Nov 15, 2021
Fix obscure bug in widening let substitution

(cherry picked from commit d343e76)
@alexreinking alexreinking removed the backport me This change should be backported to release versions label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants