-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake build rules for (some) of the generator jit tests #7693
Open
steven-johnson
wants to merge
15
commits into
main
Choose a base branch
from
srj/cmake-jit-generators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
915c46d
Add CMake build rules for (some) of the generator jit tests
steven-johnson a9d1af2
Update CMakeLists.txt
steven-johnson d3554b0
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson 0a4a456
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson 4727660
Update CMakeLists.txt
steven-johnson d3d40ca
Fix JIT skipping
steven-johnson 585abef
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson f303262
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson 7e97703
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson 91a00df
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson ec9acfb
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson ca6a774
Update cmake/HalideGeneratorHelpers.cmake
steven-johnson 29ce2cf
Update test/generator/CMakeLists.txt
steven-johnson 25852f4
Merge branch 'srj/cmake-jit-generators' of https://github.com/halide/…
steven-johnson 4f2e34c
Merge branch 'main' into srj/cmake-jit-generators
steven-johnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused but really shouldn't be... which target consumes it? It should be listed in the
target_sources
of that target.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, ok.
I'm also baffled by the build failures in apps/hannk -- something has somehow tickled the include paths in a way that makes no obvious sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a header file -- do those need to be in
target_sources
in CMake?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping re "It's just a header file -- do those need to be in target_sources in CMake?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the header file is generated, then it should be listed in some target, yes. Either:
DEPENDS
of a custom target; other targets that use the header shouldadd_dependencies
to that target.