This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add long press support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone to merge this PR? |
halilb
reviewed
Apr 13, 2017
lib/FullScreenContainer.js
Outdated
|
|
||
| // action behaviour must be implemented by the client | ||
| // so, call the client method or simply ignore this event | ||
| if (undefined !== this.props.onPhotoLongPress) { |
There was a problem hiding this comment.
how about defining a default noop onPhotoLongPress prop instead of undefined checking? Like onPhotoLongPress: () => {}
There was a problem hiding this comment.
I just copied your previous code.
halilb
reviewed
Apr 13, 2017
lib/FullScreenContainer.js
Outdated
| <TouchableWithoutFeedback | ||
| onPress={this._toggleControls} | ||
| onLongPress={this._onPhotoLongPressed} | ||
| delayLongPress={this.props.delayLongPress || 1000}> |
There was a problem hiding this comment.
Another default prop value would be better here.
|
Hey @XadillaX. Thanks for your time! I pointed two simple matters and the PR seems fine otherwise. I can merge this right away if you can take a look at them. |
XadillaX
force-pushed
the
feature/longpress
branch
from
aa64fef
to
ce4343a
Compare
|
I've updated the code. |
|
You can review the new code now. |
|
Thanks @XadillaX, it's merged now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image this situation: someone want to long press the photo to save it.